Handle the alpha component of specular-glossiness textures #9943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9928
KHR_materials_pbrSpecularGlossiness
has a diffuse texture with an alpha component. This alpha value should be used when rendering the model. SeediffuseTexture
in the specsince specular glossiness takes higher priority over metallic roughness (see the table in this section of the spec), this alpha value should override anything that came before it in the shader.
the CesiumJS implementation in
processPbrMaterials
was not doing this.diffuse.rgb
was used for PBR lighting, butdiffuse.a
was unused.ModelExperimental
was based on that file, so it also had the same problem. Fortunately, each case required only 1 line of GLSL to fix!@ebogo1 could you review?