Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove default instance #188

Merged
merged 2 commits into from
Aug 10, 2022
Merged

feat!: remove default instance #188

merged 2 commits into from
Aug 10, 2022

Conversation

alanshaw
Copy link

@alanshaw alanshaw commented Aug 9, 2022 •
edited
Loading

In Cloudflare workers you cannot call some crypto functions outside of a request:

Error: Some functionality, such as asynchronous I/O (fetch, Cache API, KV), timeouts (setTimeout, setInterval), and generating random values (crypto.getRandomValues, crypto.subtle.generateKey), can only be performed while handling a request.

This error occurs when importing the module because a default instance is created up front (the NOISE export).

This PR removes the default NOISE export to allow folks to create an instance when needed.

BREAKING CHANGE: The default instance NOISE is not longer created or exported. Import Noise and use new Noise() in place of NOISE.

resolves #180

@alanshaw alanshaw requested a review from a team as a code owner August 9, 2022 14:51
@alanshaw alanshaw changed the title refactor: remove default instance feat: remove default instance Aug 9, 2022
wemeetagain
wemeetagain approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpetrunic mpetrunic changed the title feat: remove default instance feat!: remove default instance Aug 10, 2022
@mpetrunic mpetrunic merged commit 1358409 into ChainSafe:master Aug 10, 2022
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to avoid creating the default Noise instance?
3 participants
@alanshaw @wemeetagain @mpetrunic