fix: access node process object via globalThis #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow use of noise in the browser with minimal bundling, access `process.env.FOO` via `globalThis` and with optional chaining. Removes the need to use babel etc to transpile the code first.
achingbrain
requested review from
wemeetagain,
mpetrunic,
twoeths and
dapplion
as code owners
mpetrunic
approved these changes
Mar 21, 2022
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 26 26
Lines 2864 2864
Branches 279 279
=======================================
Hits 2326 2326
Misses 538 538
Continue to review full report at Codecov.
|
|
@mpetrunic thanks for the quick review - any chance of a release with this in it please? |
|
@achingbrain Would you mind porting your auto-release infra to this library? Not time efficient to ask for releases on each timely fix |
achingbrain
added a commit
to achingbrain/js-libp2p-noise
that referenced
this pull request
Apr 11, 2022
Updates project config to add autorelease in the [unified CI model](https://github.com/protocol/.github) as requested in this comment - ChainSafe#136 (comment) Before merging this: 1. Check npm config of https://www.npmjs.com/package/@chainsafe/libp2p-noise - "Publishing access" should be set to "Require two-factor authentication or automation tokens" 2. Create a repository secret here called `NPM_TOKEN` with a npm automation token that can publish to `@chainsafe/libp2p-noise`. 3. Add https://github.com/web3-bot as a collaborator to this repo to receive automated CI config updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow use of noise in the browser with minimal bundling, access
process.env.FOOviaglobalThisand with optional chaining.Removes the need to use babel etc to transpile the code first.