-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate: getState related all regenFns's metric show empty data plus getPreState regenFn job metrics #3120
Comments
on a cursory glance, seems like queued resolveStateId either picks from stateCache, or stateArchive or constructs from stateArchive. |
@dapplion should these metrics panels be removed from regenFn Stats of the metrics dashboard? or should I aggregate all these metrics in a single widget (multiple targets), someday if something shows up we can dig deeper |
Sounds good do a PR with screen captures and let's see how it looks. If you can make all panels by 2 per row format would be great, there are still 2 full row width panels. |
@g11tech Why is the cache hit ratio negative sometimes? |
because its an approximation as we skipped counting the queued but are deriving it from queued processing. so assume at sec 1 one gets 10 requests, which gets queued, on second 2 queued length processes those 10, so delta(total) - delta(queued processed) creates these artifacts. the better solution will be to count queued in the same function scope as where we count total so that there is no drift when we do delta(total) - delta (queued). let me know if you would want me to make this change? |
The text was updated successfully, but these errors were encountered: