Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate terminal conditions of the merge block if no chain ancestor was valid in forkchoice #4305

Closed
g11tech opened this issue Jul 15, 2022 · 1 comment
Labels
spec-bellatrix 🐼 Issues targeting the merge spec version.

Comments

@g11tech
Copy link
Contributor

g11tech commented Jul 15, 2022

Moving one of the tasks of

Raised in the R& D discord for discussions and how everyone else is addressing this. may be EL validations are just enough and we don't need to do anything apart from an exchange configuration matching.

lets say we optimistically synced past merge point, like (pre-merge), (syncing), (syncing).... for a long time, eventually with new finalized(s), and pruning of pre-merge block out of forkchoice
so now fcU chain is syncing,syncing,...syncing, now if the valid comein , the terminal conditions need to be verified of the terminal pow block,

(essentially each time one gets valid and tries to percolate and see that all ancestors in forkchoice of that chain are syncing which obviously will now be flipped to valid )

Question is how to get the handle of that terminal block to fetch its properties from the execution engine, it is quite possible that its on a sidechain of the terminal block which was fetched/cached by the merge block finder tracker

Although execution engine would have ran its own terminal validations before returning valid on that chain, so may be we can just happily accept it (which is what happens now as well), so do we need to run double check and how (and if we don't why do we need to run the check in the first place)
or should it be resolved via an exchange config call when this happens (and do validations there upon)

@philknows philknows added the spec-bellatrix 🐼 Issues targeting the merge spec version. label Aug 12, 2022
@g11tech
Copy link
Contributor Author

g11tech commented May 29, 2023

since the mainnet has moved past the merge this issue is no more relevant as all weaksubjectivity checkpoints start post merge.

@g11tech g11tech closed this as completed May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bellatrix 🐼 Issues targeting the merge spec version.
Projects
None yet
Development

No branches or pull requests

2 participants