Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue with stablelib #4652

Closed
twoeths opened this issue Oct 8, 2022 · 3 comments · Fixed by #4787
Closed

Performance issue with stablelib #4652

twoeths opened this issue Oct 8, 2022 · 3 comments · Fixed by #4787
Assignees
Labels
scope-performance Performance issue and ideas to improve performance.

Comments

@twoeths
Copy link
Contributor

twoeths commented Oct 8, 2022

Description

  • The js version of chacha20poly1305 takes significant time in lodestar

Screen Shot 2022-10-08 at 17 29 10

Need to find a different implementation:

@dapplion
Copy link
Contributor

dapplion commented Oct 8, 2022

  • @tuyennhv Opened a PR feat: add metrics js-libp2p-noise#224 to add metrics to noise, relevant to this issue is to measure packet rate inbound and outbound so we can understand how expensive noise is relative to benchmarks

@mpetrunic
Copy link
Member

I don't think it makes sense to track it in this repository as this library allows you to add your own cryptography libraries

@twoeths twoeths transferred this issue from ChainSafe/js-libp2p-noise Oct 9, 2022
@twoeths twoeths self-assigned this Oct 11, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Oct 19, 2022

This is from v1.2.0-rc.0 goerli lg1k, it shows how chacha20Poly1305Decrypt() could cause I/O lag issue

  • At 531044 ms

Screen Shot 2022-10-19 at 14 30 13

  • At 531153 ms

Screen Shot 2022-10-19 at 14 31 10

  • At 531207 ms

Screen Shot 2022-10-19 at 14 32 44

although each call takes only ~6ms, it's significant compared to others
Screen Shot 2022-10-19 at 14 39 18

1019_feat2_lg1k_1.2.0_rc.0.cpuprofile.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants