Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC cannot decrypt keystores with encryption password ending in specific character(s) #5276

Closed
philknows opened this issue Mar 16, 2023 · 2 comments · Fixed by #5282
Closed
Assignees
Labels
prio-high Resolve issues as soon as possible.

Comments

@philknows
Copy link
Member

Describe the bug

The validator client is unable to decrypt a keystore if the encryption password ends in the | character. I haven't tried to see if other characters create the same behaviour, but this character triggers it and you will receive the following response in the VC:

  Error: Invalid password
    at Object.<anonymous> (/usr/app/node_modules/@chainsafe/bls-keystore/lib/functional.js:86:19)
    at Generator.next (<anonymous>)
    at fulfilled (/usr/app/node_modules/@chainsafe/bls-keystore/lib/functional.js:5:58)

Will update if other characters trigger the same result

Expected behavior

Passwords should be able to use any special character and not encounter errors during decryption.

Steps to Reproduce

  1. Create a keystore.json file and encrypt it with a password ending in |
  2. Run the VC on this keystore
  3. Observe Error: Invalid password response

Screenshots
Screenshot 2023-03-16 at 5 35 31 PM

Desktop (please complete the following information):

  • OS: Ubuntu 22.04.1
  • Version: v1.5.1/3d937ee
  • Branch: unstable
  • Commit hash: 3d937ee
@philknows philknows added the prio-high Resolve issues as soon as possible. label Mar 16, 2023
@dapplion
Copy link
Contributor

@nflaig can you take a look?

@nflaig
Copy link
Member

nflaig commented Mar 18, 2023

@dapplion have it on my list already, will look into it today/tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-high Resolve issues as soon as possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants