Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API versionning #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add API versionning #65

wants to merge 2 commits into from

Conversation

Antoninbln
Copy link
Contributor

@Antoninbln Antoninbln commented Jul 27, 2020 •
edited
Loading

Issue #66

This PR is a proposal.

What have been done :

  • Split api folder into multiple version specific modules
  • Add apis getter

@Antoninbln Antoninbln requested a review from a team as a code owner July 27, 2020 14:03
@Antoninbln Antoninbln force-pushed the TECH-add-api-versionning branch 3 times, most recently from d39cebf to 8fef59e Compare July 27, 2020 14:18
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        28    +1     
  Lines          590       593    +3     
  Branches        57        58    +1     
=========================================
+ Hits           590       593    +3
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...or_api/api/api_routes/v1/builds/register_routes.py 100.00% <ø> (ø)
nestor_api/api/api.py 100.00% <100.00%> (ø)
nestor_api/api/api_routes/v1/api.py 100.00% <100.00%> (ø)
nestor_api/api/api_routes/v1/builds/build_app.py 100.00% <100.00%> (ø)
nestor_api/api/flask_app.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ca55b...273f7b9. Read the comment docs.

Kenny407
Kenny407 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@Kenny407 Kenny407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it looks pretty good, and looks maintainable in case we want to move forward to having several versions 👍 . I would ask for the eyes of the others too just to confirm.

@chris-verclytte chris-verclytte linked an issue Jul 28, 2020 that may be closed by this pull request
Discuss about adding an API versionning. #66
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenny407 Kenny407 Kenny407 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discuss about adding an API versionning.
2 participants
@Antoninbln @Kenny407