Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MicroWin] ISO Downloader Enhancements #2787

Merged

Conversation

CodingWonders
Copy link
Contributor

@CodingWonders CodingWonders commented Sep 21, 2024

Type of Change

  • New feature
  • Bug fix
  • UI/UX improvement

Description

This PR improves upon the work for the MicroWin ISO downloader from @MyDrift-user (#2581) in the following ways:

  • It fixes issues related to Get-ChildItem which, at least in PowerShell 5, was causing problems due to its entire output being passed to the file path
  • It modifies the first element in the language list, which is determined by my Get-FidoLangFromCulture cmdlet, to always say "System language (<Fido-approved language>)". This avoids having duplicate items when the time comes to add more languages:

  • It allows the user to move the ISO file to his/her preferred location, thereby avoiding the use of the $env:TEMP folder when possible:

  • Finally, it adds error handling in the case of a ban on the software download service:

Testing

Testing has concluded without issues, but with some temporary bans on the software download service

Impact

More robust and reliable downloader

Issue related to PR

None

Additional Information

Currently requires no documentation changes

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

- Changed the first item in the language list to show "System language". Then we determine it and download it
- Fixed an issue where the entire contents of `gci` were being passed to the variable, which causes the rest to fail
@CodingWonders CodingWonders marked this pull request as ready for review September 23, 2024 14:31
@ChrisTitusTech ChrisTitusTech merged commit 102231c into ChrisTitusTech:main Sep 23, 2024
1 check passed
@CodingWonders CodingWonders deleted the microwin-iso-downloader-v2 branch October 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants