Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge NpmIntellisense into this extension #9

Closed
eyalellenbogen opened this issue May 4, 2016 · 5 comments
Closed

Merge NpmIntellisense into this extension #9

eyalellenbogen opened this issue May 4, 2016 · 5 comments

Comments

@eyalellenbogen
Copy link

Hi again,

What do you think about merging your other extension (https://github.com/ChristianKohler/NpmIntellisense) with this one?

I think it makes sense to have one extension take care of import statements.

E

@donaldpipowitch
Copy link

donaldpipowitch commented May 9, 2016

I also use them together and have a problem: say I'd like to import a relative file and want to type ./ the . will trigger "accept" and accepts the first suggested npm module. I can't find the corresponding shortcut to change this behaviour :/

Update

The same problem exists for relative paths like ../../. The third . (say ../.) will accept the first suggested file.

@dbettini
Copy link

dbettini commented Jul 8, 2016

@donaldpipowitch the solution is to unbind .. Add this to keybindings.json:
{ "key": ".", "command": "" }

@ChristianKohler
Copy link
Owner

@dbettini Thank you for the hint. Didn't know that. I also added ".." as first suggestion which makes it even faster since you only have to hit enter.

@donaldpipowitch
Copy link

Awesome, thanks.

@ChristianKohler
Copy link
Owner

@eyalellenbogen: PathIntellisense is not just for import statements but for path completion in general. You can for example also autocomplete url in html src attributes. Also in a few years, npm could be replaced by another package manager while autocompletion for paths is something I don't expect to go away soon. This is why I created two extension separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants