Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are gone? #190

Closed
superm1991 opened this issue Oct 30, 2021 · 7 comments
Closed

Filters are gone? #190

superm1991 opened this issue Oct 30, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@superm1991
Copy link

I don't see filter options in store pages anymore...

@ChristopherKlay
Copy link
Owner

Yea, Stadia made changes to the store (and lots of other parts).

Will push out a hotfix later today (:

@ChristopherKlay ChristopherKlay added the bug Something isn't working label Oct 31, 2021
@ChristopherKlay
Copy link
Owner

A little update:

The changes are sadly bigger than i hoped and i had to make some drastic changes to how store elements are filtered out, because the actual store entry doesn't contain any informations about the type of entry (i.e. game, bundle, addon) anymore, outside of the actual text on the UI element. They also removed the game/store ID from those entries entirely.

The hotfix will restore the filter for games, bundles and addons (by using language based filtering, similar to the letterbox filter in the library), but the wishlist function is going to be deactivated for now, at least until i can find another way to make it work - or Stadia hopefully provides their own solution.

@superm1991
Copy link
Author

Oh wow, that's bad news!
But thanks for the update!

@ChristopherKlay
Copy link
Owner

image
Filters are already working again in the dev build, wishlisting is - as far as i can tell - currently not possible anymore, however.

Previously, games included the type of entry in their attributes, i.e. 17:3, so filtering them via specific CSS rules was possible, but those attributes have been removed. I went ahead and gathered the actual text strings used by Stadia for the currently supported languages and implemented a filtering process based on those, which runs fine - but has to be manually updated. If the filter options aren't showing up in a specific (Stadia-supported) language in the future, adding them is quick and easy as well.

Wishlisting however, was based on store entries also featuring the given ID of each specific store entry (so games and their deluxe versions had different ID's, for example). Those infos have been replaced with action triggers that load the store page, without the ID being accessible from the DOM element anymore. The hotfix will hide the wishlisting functionality for now, until i find a way to implement it again - any wishlists saved in user profiles will be kept for the future.

@ChristopherKlay
Copy link
Owner

1.17.6 just went into verification and should fix the store filtering.

Let me know if it works (:

@superm1991
Copy link
Author

Yes, it's working fine with 1.17.6 (my Stadia account is in English).
Thanks again!

(And I hope we get a solution for the wishlist at some point :) )

@ChristopherKlay
Copy link
Owner

I tested a few other languages as well and everything should work.

We'll see about wishlisting. I'll implement when i can, but i hope Stadia does it first :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants