fix: used event.composedPath instead of the deprecated event.path #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, should've made an issue first, as a dev i figured i'd just fix it... I should know better, sorry! |
|
Will push a hotfix including this in a minute, also fixed it for the notification system using the same path attribute. Thank you for bringing this up!
Next time. It's fine (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris,
As per https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath
event.path is being removed in Chrome v105+ (current chrome dev channel at time of PR)
This is the patch for the replacement as currently the settings menu will not open =)