From d0a1e4ff86ececb14243938f9adf589ba77b96a4 Mon Sep 17 00:00:00 2001 From: Liam Clarke Date: Thu, 22 Aug 2024 09:34:05 +0100 Subject: [PATCH] PIPE-4877 Remove config validate test with invalid org ID There has been a change to how configs are compiled that makes this test invalid. Previously we would allow any random owner ID to be passed in when compiling certified orbs as these were enabled by default and didn't require any checks with the provided owner ID. To support an upcoming feature, now when compiling the config, all provided owner IDs are checked and must exist to validate that the organization allows that type of orb. The CLI can continue to use no owner ID with public certified orbs as tested in the above case. https://github.com/CircleCI-Public/circleci-cli/blob/2766f0e710c8727e346e247f6c779079a79b010c/integration_tests/features/circleci_config.feature#L63-L85 --- .../features/circleci_config.feature | 24 ------------------- 1 file changed, 24 deletions(-) diff --git a/integration_tests/features/circleci_config.feature b/integration_tests/features/circleci_config.feature index 9628d3bf3..17354219b 100644 --- a/integration_tests/features/circleci_config.feature +++ b/integration_tests/features/circleci_config.feature @@ -84,30 +84,6 @@ Feature: Config checking Then the exit status should be 0 And the output should contain "Config file at config.yml is valid" - Scenario: Checking a valid config file with a private org - Given a file named "config.yml" with: - """ - version: 2.1 - - orbs: - node: circleci/node@5.0.3 - - jobs: - datadog-hello-world: - docker: - - image: cimg/base:stable - steps: - - run: | - echo "doing something really cool" - workflows: - datadog-hello-world: - jobs: - - datadog-hello-world - """ - When I run `circleci config validate --skip-update-check --org-id bb604b45-b6b0-4b81-ad80-796f15eddf87 -c config.yml` - Then the output should contain "Config file at config.yml is valid" - And the exit status should be 0 - Scenario: Checking a valid config file with a non-existant orb Given a file named "config.yml" with: """