Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing an orb with setup: true in the example, does not include setup: true #779

Closed
imlogang opened this issue Sep 15, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@imlogang
Copy link

Meta:

CircleCI CLI Version:

Operating System:

CircleCI CLI Diagnostic:


Current behavior:

When publishing an Orb with setup: true in an example on how to use a command, the example is published without setup: true.

Expected behavior:

setup: true be included in the example.

When did this begin / Was this previously working?:

First reported 9/15/22

Additional Information:

@imlogang imlogang added the bug Something isn't working label Sep 15, 2022
@KyleTryon
Copy link
Contributor

Setup is not included in the struct:

type ExampleUsageSchema struct {

@adamdmharvey
Copy link
Contributor

adamdmharvey commented Sep 30, 2022

@KyleTryon is adding setup to the struct the only change that might be needed? If so I'm happy to fire that PR, but not sure the steps necessary in the broader context of how do we get examples published to the orb catalog with setup: true included :)

@JulesFaucherre
Copy link
Contributor

Hey, getting back to this a bit late!

Thanks for the PR @adamdmharvey, since it is merged and released, I close the issue

@adamdmharvey
Copy link
Contributor

Confirmed this now works! yay!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants