Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we actually include totalSupply? #17

Open
metachris opened this issue Aug 10, 2018 · 3 comments
Open

Should we actually include totalSupply? #17

metachris opened this issue Aug 10, 2018 · 3 comments

Comments

@metachris
Copy link

Currently the token list includes total supply. Is this used for something? Wondering if it's a good idea, because some tokens have a variable total supply that increases over time (eg. red pulse).

@corck
Copy link
Contributor

corck commented May 29, 2019

Same here, for our Gold token total supply doesn't make sense as we mint as soon as we store more Gold.

@mhuggins
Copy link
Contributor

Just to add a little history here, there was a nightly job that ran on CircleCI to regularly update these values. However, I think @comountainclimber disabled them due to some issues with the notification server intermittently having wrong/bad data.

@comountainclimber
Copy link
Member

Yeah that is correct... There was an incident where the job just copied over an empty list causing some serious problems. If we could get some test coverage in that would solve this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants