Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum_xspacing does not account for the immersed boundary #3954

Open
simone-silvestri opened this issue Nov 23, 2024 · 2 comments · May be fixed by #3955
Open

minimum_xspacing does not account for the immersed boundary #3954

simone-silvestri opened this issue Nov 23, 2024 · 2 comments · May be fixed by #3955

Comments

@simone-silvestri
Copy link
Collaborator

I think it's because of these definitions

xspacings(ibg::ImmersedBoundaryGrid, ℓ...) = xspacings(ibg.underlying_grid, ℓ...)
yspacings(ibg::ImmersedBoundaryGrid, ℓ...) = yspacings(ibg.underlying_grid, ℓ...)
zspacings(ibg::ImmersedBoundaryGrid, ℓ...) = zspacings(ibg.underlying_grid, ℓ...)

This causes the CFL to be limited by possibly immersed nodes.
It is quite relevant on the TripolarGrid where nodes near the north poles are immersed with the spacings tending to zero.

I can open a PR to fix this.

@glwagner
Copy link
Member

Nice find. Also we should note that the immersed boundary grid can change the spacings (in addition to the fact that we must omit immersed spacings). For example with partial cells the zspacings are different than on the underlying grid.

@glwagner
Copy link
Member

cc @ali-ramadhan I'm not sure if this was bundled with other changes you made but a good thing to be aware of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants