Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver broken due to custom sparse serialisation not supported with ClickHouse 23.7 #1048

Closed
jkaflik opened this issue Jul 31, 2023 · 2 comments · Fixed by #1059
Closed

Driver broken due to custom sparse serialisation not supported with ClickHouse 23.7 #1048

jkaflik opened this issue Jul 31, 2023 · 2 comments · Fixed by #1059
Labels
bug

Comments

@jkaflik
Copy link
Contributor

jkaflik commented Jul 31, 2023 •
edited
Loading

Describe the bug

Steps to reproduce

This is reproducible using tests against ClickHouse 23.7 or newer. Breaks working with clickhouse-go with the newest versions of ClickHouse.

Error: https://github.com/ClickHouse/clickhouse-go/actions/runs/5688584217/job/15479144836#step:4:678

Expected behaviour

No error appears.
This is likely due to a change in ClickHouse introduced in: ClickHouse/ClickHouse#49631

Driver (ch-go as well) does not support custom sparse serialization.

A possible walkaround is to set ratio_of_defaults_for_sparse_serialization = 1 for MergeTree tables.
@jkaflik jkaflik changed the title Custom serialisation not supported error for ClickHouse 23.7 Driver broken due to custom serialisation not supported error for ClickHouse 23.7 Jul 31, 2023
@jkaflik jkaflik changed the title Driver broken due to custom serialisation not supported error for ClickHouse 23.7 Driver broken due to custom sparse serialisation not supported in ClickHouse 23.7 Jul 31, 2023
@jkaflik jkaflik removed the P1 label Jul 31, 2023
@jkaflik
Copy link
Contributor Author

jkaflik commented Jul 31, 2023

This goes to be fixed by bumping min protocol required version in ClickHouse: ClickHouse/ClickHouse#52835

@jkaflik jkaflik mentioned this issue Aug 2, 2023
Merged
@jkaflik jkaflik changed the title Driver broken due to custom sparse serialisation not supported in ClickHouse 23.7 Driver broken due to custom sparse serialisation not supported with ClickHouse 23.7 Aug 2, 2023
@jkaflik jkaflik mentioned this issue Aug 3, 2023
Merged
@jkaflik
Copy link
Contributor Author

jkaflik commented Aug 3, 2023

Sparse serialization support will be followed up at #1058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore test against CH 23.7 ClickHouse/clickhouse-go
1 participant
@jkaflik