Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch.Append with boolean fields in map representing JSON column fails #1072

Closed
ilyabreev opened this issue Aug 22, 2023 · 1 comment · Fixed by #1073
Closed

batch.Append with boolean fields in map representing JSON column fails #1072

ilyabreev opened this issue Aug 22, 2023 · 1 comment · Fixed by #1073
Assignees
@jkaflik
Labels
bug

Comments

@ilyabreev
Copy link

Describe the bug

Steps to reproduce

  1. Call batch.Append or batch.AppendStructure passing json map with boolean field
  2. Call it one more time with same data
  3. Fail with error "type mismatch in column expected Bool but got Boolean"

Expected behaviour

Data appended to batch

It seems like error is in this line:
https://github.com/ClickHouse/clickhouse-go/blob/main/lib/column/json.go#L43

If I replace Bool with Boolean it works like a charm.
@ilyabreev ilyabreev added the bug label Aug 22, 2023
@jkaflik jkaflik self-assigned this Aug 22, 2023
@jkaflik
Copy link
Contributor

jkaflik commented Aug 22, 2023

@ilyabreev, thanks for reporting this. This is an odd bug. Thanks for your investigation. The fix is on the way!

@jkaflik jkaflik mentioned this issue Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkaflik jkaflik

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(column.json): fix bool type handling ClickHouse/clickhouse-go
2 participants
@jkaflik @ilyabreev