Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version detection #2007

Closed
Paultagoras opened this issue Dec 8, 2024 · 2 comments · Fixed by #2054
Closed

Fix version detection #2007

Paultagoras opened this issue Dec 8, 2024 · 2 comments · Fixed by #2054
Assignees
Milestone

Comments

@Paultagoras
Copy link
Contributor

Paultagoras commented Dec 8, 2024

Problems to solve:

  • Reports a wrong client version or update didn’t happen.
  • Reports never released kafka connector version (v1.2.10)
  • The existing tests haven't caught the problem

Currently we're defaulting to 0.6.3:

public static final String LATEST_KNOWN_VERSION = "0.6.3";

We need to find a more reliable way to determine the version...

@Paultagoras Paultagoras added the bug label Dec 8, 2024
@mshustov
Copy link
Member

mshustov commented Dec 9, 2024

or don't guess and set a well-known indicator like unknown, which would help us to detect problems earlier and fix them

@chernser chernser added client-api-v2 module-http HTTP/HTTPS client labels Dec 9, 2024
@chernser chernser added this to the 0.7.2 milestone Dec 12, 2024
@chernser chernser self-assigned this Dec 12, 2024
@chernser
Copy link
Contributor

@mshustov we need to know at least aprox. version - so I've added ~ to version constant.
Event if we missed updating it - we will get something ~0.7.2.
Please let me know if this will work.

Thanks!

@laeg laeg added Java JDBC labels Jan 16, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants