New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No bottom spacing for code blocks #32

Open

ozgunozerk opened this issue May 26, 2024 · 0 comments · May be fixed by #33

ozgunozerk commented May 26, 2024 •

edited

Loading

In here: https://github.com/CloudCannon/vonge-jekyll-bookshop-template/blob/main/component-library/shared/styles/2-base/_base.scss#L114

It is specifically set to 0.

Currently, it causes code blocks to look like this:

I think this is best practice from UI point of view to add some margin in here like shown:

The text was updated successfully, but these errors were encountered:

ozgunozerk linked a pull request

that will close this issue

fix pre block bottom-margin #33

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment