Add pod repo remove [name] command #1493
Conversation
Deletes the repo named in the command.
|
Wow! Ace. Nice first PR, good spot that git use |
| @@ -16,7 +16,7 @@ module Pod | |||
| Command.parse(%w{ setup }).should.be.instance_of Command::Setup | |||
| Command.parse(%w{ spec create }).should.be.instance_of Command::Spec::Create | |||
| Command.parse(%w{ spec lint }).should.be.instance_of Command::Spec::Lint | |||
| Command.parse(%w{ repo update }).should.be.instance_of Command::Repo::Update | |||
There was a problem hiding this comment.
I don't think tha removing this line was intentional :-)
There was a problem hiding this comment.
I was going to ask about that. There were two asserts for repo update that were identical. I can add this one back in but it seemed unusual to verify that the parser works for the same command twice. However, I'll definitely change it if there was a reason for it :)
There was a problem hiding this comment.
Indeed you're right 👍. However it might make sense to keep them grouped by command. I.e. move this line up with the other repo checks.
|
Looks great, do you mind adding a note to the changelog crediting yourself? |
|
👍 Thanks for the contribution! |
Add pod repo remove [name] command
Deletes the repo named in the command. As requested by @orta in #1484. Not the best at ruby, but I think this should do the trick.