Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force curl to use HTTP/1.1 #86

Open
1 task done
nrbrook opened this issue Jan 31, 2019 · 5 comments
Open
1 task done

Force curl to use HTTP/1.1 #86

nrbrook opened this issue Jan 31, 2019 · 5 comments

Comments

@nrbrook
Copy link

nrbrook commented Jan 31, 2019

Report

My podspec has a source zip on a server that supports HTTP/2. Curl 7.54.0 in the latest macOS 10.14.2 (18C54) has a bug which causes issues with files fetched over HTTP/2. Therefore my pod keeps failing to validate and install for users. I don't think there is a way in my podspec to provide flags to curl is there? Are there any other possible solutions?

@dnkoutso
Copy link
Contributor

dnkoutso commented Feb 2, 2019

This is a change in cocoapods-downloader. Moving issue there.

@dnkoutso dnkoutso transferred this issue from CocoaPods/CocoaPods Feb 2, 2019
@endocrimes
Copy link
Member

I think the correct fix for this would be to only disable HTTP 2 when running with curl 7.54.0, but doing so in such case sgtm if macOS shipped a broken version.

@nrbrook
Copy link
Author

nrbrook commented Feb 2, 2019

That sounds good although it would also be useful to have an option on “source” for curl flags, but I’m just hoping for any solution at the moment as I don’t currently have one other than ‘keep trying’

@nrbrook
Copy link
Author

nrbrook commented Feb 2, 2019

Also other past (and future) versions of macOS might have this issue, 7.54.0 is not a very recent release, so it might be better just to disable http2 until Apple update curl

@nrbrook
Copy link
Author

nrbrook commented Feb 2, 2019

Or, better still, check the curl version not macOS version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants