Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to manually start the browser. #255

Merged
merged 4 commits into from
Oct 18, 2016
Merged

Added option to manually start the browser. #255

merged 4 commits into from
Oct 18, 2016

Conversation

HerrLapsus
Copy link
Contributor

To work with cloud services like browserstack it can be beneficial to control when the session is started and therefore start the session manually.

One case in which this is useful is issue #190. You can set the desiredCapability.name and then start the session by executing this.helpers['WebDriverIO']._startBrowser()

As the manual option is set to false by default the behavior doesn't change.

@DavertMik
Copy link
Contributor

Thanks for the PR. I like the implementation but I don't like naming, probably they should be more explicit about the problem it solves. manualStart looks like it expects you to launch a browser locally and wait the Selenium to handle its session (somehow).

Maybe it should be named like reuseSession or smth else... With documentation for potential use case at cloud service providers

@DavertMik
Copy link
Contributor

@cnworks when I merge your PR could you help the project a bit more. I was thinking it would be useful to have dedicated "Cloud Testing" guide in documentation. Could you write some paragraphs on it, to share your experience?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants