Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context Providers are unnecessary runned on checkout -> select payment page #139

Open
arti0090 opened this issue Oct 30, 2024 · 1 comment

Comments

@arti0090
Copy link
Contributor

I saw when debugging that on Checkout->select payment Context Providers: RegulationsUrlContextProvider and BankListContextProvider are ran unnecessary.
We could investigate why does it happens cause it might impact performance of the feature.
On my last try they ran:

  • BankListContextProvider 10 times (it has calls to API (cached) and DB inside)
  • RegulationsUrlContextProvider 50+ times 😱

Steps to reproduce:

  • create order with any shipment and total more than 0.01
  • go to select payment page
  • on any of these providers 'provide' function put a breakpoint and count 🙃
@coldic3
Copy link
Member

coldic3 commented Nov 15, 2024

I believe the BankListContextProvider was optimized to fetch channels only with PBL, but this was removed here: https://github.com/CommerceWeavers/SyliusTpayPlugin/pull/100/files#diff-a7732c1da78e6bf7b920a5cdd30d6ee2f05628fb2325312afa92fca439902a41L36 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants