Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the code coverage #96

Open
3 tasks
jakubtobiasz opened this issue Oct 18, 2024 · 1 comment
Open
3 tasks

Increase the code coverage #96

jakubtobiasz opened this issue Oct 18, 2024 · 1 comment
Labels
dx Developer Experience improvements

Comments

@jakubtobiasz
Copy link
Member

Currently with the following configuration:

    <coverage>
        <include>
            <directory suffix=".php">src</directory>
        </include>
        <exclude>
            <directory>src/Api/Doctrine</directory>
            <directory>src/Api/Resource</directory>
            <directory>src/Controller</directory>
            <directory>src/DependencyInjection</directory>
            <directory>src/Fixture</directory>
            <directory>src/Form</directory>
            <directory>src/Model</directory>
            <directory>src/Test</directory>
            <directory>src/Twig</directory>
            <file>src/CommerceWeaversSyliusTpayPlugin.php</file>
        </exclude>
    </coverage>

our code coverage is about 80%. As we always aim higher in terms of quality, we should at later point take care about this metric.

Small wins 🏆

  • Total code coverage is at least 90%
  • This extension is installed
  • CI reports if the code coverage is below 90%
@jakubtobiasz jakubtobiasz added the dx Developer Experience improvements label Oct 18, 2024
@arti0090 arti0090 self-assigned this Oct 24, 2024
@lchrusciel lchrusciel added this to the 2.0.0 milestone Nov 4, 2024
@arti0090 arti0090 removed their assignment Nov 5, 2024
@arti0090
Copy link
Contributor

arti0090 commented Nov 5, 2024

#106 in the time of creation solved 1st and 2nd task from TODO list. I didn't do anything regarding CI on it.
As it was some time ago, rebase will be needed and possible adjustment but overall this PR should solve quite a bit of this task

@lchrusciel lchrusciel removed this from the 2.0.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience improvements
Projects
None yet
Development

No branches or pull requests

3 participants