Skip to content

Commit

Permalink
refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn (co…
Browse files Browse the repository at this point in the history
…smos#1188)

* refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn

* chore: updating changelog and comment for deprecated notice

* fix: channel proto file linter issue + adding deprecated flag to MsgSubmitMisbehavior

* chore: fix changelog
  • Loading branch information
seantking authored and oshorefueled committed Aug 9, 2022
1 parent ebd2641 commit 7cb5ea8
Show file tree
Hide file tree
Showing 7 changed files with 151 additions and 143 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
### State Machine Breaking

### Improvements
* (modules/core/02-client) [\#1188](https://github.com/cosmos/ibc-go/pull/1188/files) Routing `MsgSubmitMisbehaviour` to `UpdateClient` keeper function. Deprecating `SubmitMisbehaviour` endpoint.


* (modules/core/02-client) [\#1208](https://github.com/cosmos/ibc-go/pull/1208) Replace `CheckHeaderAndUpdateState` usage in 02-client with calls to `VerifyClientMessage`, `CheckForMisbehaviour`, `UpdateStateOnMisbehaviour` and `UpdateState`.
* (modules/light-clients/09-localhost) [\#1187](https://github.com/cosmos/ibc-go/pull/1187/) Removing localhost light client implementation as it is not functional.
Expand Down
13 changes: 7 additions & 6 deletions docs/ibc/proto-docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2060,9 +2060,9 @@ ResponseResultType defines the possible outcomes of the execution of a message

| Name | Number | Description |
| ---- | ------ | ----------- |
| RESPONSE_RESULT_UNSPECIFIED | 0 | Default zero value enumeration |
| RESPONSE_RESULT_NOOP | 1 | The message did not call the IBC application callbacks (because, for example, the packet had already been relayed) |
| RESPONSE_RESULT_SUCCESS | 2 | The message was executed successfully |
| RESPONSE_RESULT_TYPE_UNSPECIFIED | 0 | Default zero value enumeration |
| RESPONSE_RESULT_TYPE_NOOP | 1 | The message did not call the IBC application callbacks (because, for example, the packet had already been relayed) |
| RESPONSE_RESULT_TYPE_SUCCESS | 2 | The message was executed successfully |


<!-- end enums -->
Expand Down Expand Up @@ -2487,13 +2487,14 @@ MsgCreateClientResponse defines the Msg/CreateClient response type.
### MsgSubmitMisbehaviour
MsgSubmitMisbehaviour defines an sdk.Msg type that submits Evidence for
light client misbehaviour.
Warning: DEPRECATED


| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `client_id` | [string](#string) | | client unique identifier |
| `misbehaviour` | [google.protobuf.Any](#google.protobuf.Any) | | misbehaviour used for freezing the light client |
| `signer` | [string](#string) | | signer address |
| `client_id` | [string](#string) | | **Deprecated.** client unique identifier |
| `misbehaviour` | [google.protobuf.Any](#google.protobuf.Any) | | **Deprecated.** misbehaviour used for freezing the light client |
| `signer` | [string](#string) | | **Deprecated.** signer address |



Expand Down
86 changes: 44 additions & 42 deletions modules/core/02-client/types/tx.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 7cb5ea8

Please sign in to comment.