Refine minor improvements

[jaybxyz]

Description

This PR refines minor improvements:

• Remove pending TODO comment of how to set authority.
  • NewBaseKeeper it is set with governance module account in app.go)
• Remove duplicate validation in AddAccountToFundModuleSet as stateless check is already done during CheckTx.
• Fix ValidateBasic for MsgAddAccountToFundModuleSet. It was validating the same address twice.
• Use types.ModuleName throughout the modules instead of constant value. Notice that the ratelimit module was having transfermiddleware value in its tx.go.

Please, feel free to let me know if there are other minor improvements that can be made in this PR. I am happy to contribute.

[jaybxyz]

@GNaD13 @vuong177 Interchain Tests workflow action fails due to the following error. Do you have any idea how to resolve this?

Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/notional-labs/centauri-ictest:latest: unexpected status from POST request to https://ghcr.io/v2/notional-labs/centauri-ictest/blobs/uploads/: 403 Forbidden

[vuong177]

@anhductn2001 could you check the ghrc problem? I think we need to add @jaybxyz to centauri repo ghrc.

[anhductn2001]

Ok, Let me see! Seem like login ghcr.io step was success.

[anhductn2001]

I think the problem maybe come from your source repo @jaybxyz. We can temporarily skip this test!

[jaybxyz]

I think it is known issue. It seems like a lot of devs are experiencing the same / similar issue. Let me try some of the solutions and see if it works.

1. Some suggests to create a new Docker image (UPDATE: seems like it is only a temporary solution)
2. (Not working) Some suggests to add an explicit permissions to the .yml file

    permissions:
      contents: read
      packages: write

3. (Not working) Replace github.repository_owner to github.actor

References

• raise ghcr unexpected status: 403 Forbidden when push ghcr image docker/build-push-action#687
• build-push to Github Container Rigistry 403/499 errors docker/build-push-action#651
• Random 403 errors when pushing to GHCR docker/build-push-action#463

[jaybxyz]

@vuong177 @anhductn2001 Can you reference this https://github.com/orgs/community/discussions/26274#discussioncomment-3251137 and try to see if it works? Otherwise, i don't know how to resolve this strange issue.

So to fix this, head over to $yourOrganization → Packages → $yourPackage → Package settings (to the right / bottom)

And configure “Manage Actions access” section to allow the git repository in question write permissions on this package/docker repository

[anhductn2001]

I'm pretty sure we have write permission set for it. This is an issue related to Github Action that I recently encountered when creating a PR to a repository from our Notional-labs fork source.

[jaybxyz]

@anhductn2001 Are you trying something to resolve this issue in #243 ? I've tried to add an explicit permission but it didn't resolve. See 5076078.

[anhductn2001]

Yes, @jaybxyz. I just add permission in another place. Can you merge master to your branch?

[jaybxyz]

@anhductn2001 It doesn't seem to resolve the issue. What else can we try? Some suggests to create a new Docker image ghcr.io/notional-labs/centauri-ictest:latest.

[anhductn2001]

Perhaps this is a Github issue. I think first let's review and merge it to master. Because build and push images on master and all other branches are working normally.

[jaybxyz]

@anhductn2001 What is the protocol regarding the review process? Am I allowed to merge after at least one reviewer has completed their review?

[anhductn2001]

I think we should need 2 approvals. Let's wait @vuong177 review it!

[vuong177]

good catch! we don't duplicate SDK process!