Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'type' column from 'wallet' table - upgrade knex (tech debt) #325

Open
orhoj opened this issue Jun 20, 2022 · 0 comments
Open

Remove 'type' column from 'wallet' table - upgrade knex (tech debt) #325

orhoj opened this issue Jun 20, 2022 · 0 comments
Labels
[Type] Task An additional feature or improvement.

Comments

@orhoj
Copy link
Contributor

orhoj commented Jun 20, 2022

Task description
The type column of the wallet table is unused, and in some cases it contains an incorrect value. The column should be dropped. Dropping the column is non-trivial as SQLite does not support this in an alter table command. We may have to upgrade the knex dependency to be able to turn off foreign_key constraint checks during the migration, as it does not seem to be possible to do that while keeping the onCreate method that turns on the check with our current version.

@orhoj orhoj added the [Type] Task An additional feature or improvement. label Jun 20, 2022
@orhoj orhoj mentioned this issue Jun 20, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task An additional feature or improvement.
Projects
None yet
Development

No branches or pull requests

1 participant