Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Implement easy capture of output (for tests) #2034

Closed
raulb opened this issue Dec 19, 2024 · 0 comments · Fixed by #2104
Closed

CLI: Implement easy capture of output (for tests) #2034

raulb opened this issue Dec 19, 2024 · 0 comments · Fixed by #2104
Assignees
@raulb

Comments

@raulb
Copy link
Member

raulb commented Dec 19, 2024 •
edited
Loading

Similarly to how we implemented it in meroxa's CLI: https://github.com/meroxa/cli/tree/4836e3d078f42ae19e48234d24300bac50e62734/log

Requirements are an easy way to overwrite the stdout on tests so we could compare the execution output with the expected one.

Note

It needs ConduitIO/ecdysis#11

Part of #1911
This was referenced Dec 19, 2024
Open
Merged
@raulb raulb moved this from Triage to Todo in Conduit Main Dec 19, 2024
@raulb raulb self-assigned this Jan 23, 2025
@raulb raulb moved this from Todo to In Progress in Conduit Main Jan 23, 2025
@raulb raulb changed the title CLI: Implement Conduit Logger CLI: Implement easy capture of output (for tests) Jan 24, 2025
This was referenced Jan 24, 2025
Merged
Merged
@raulb raulb moved this from In Progress to Ready for review in Conduit Main Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Conduit Main Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulb raulb

Labels
None yet
Projects
Conduit Main
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use output decorator, adding tests ConduitIO/conduit
1 participant
@raulb