Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed videos to pages #274

Closed
1 task
darwintree opened this issue Nov 29, 2023 · 5 comments
Closed
1 task

Embed videos to pages #274

darwintree opened this issue Nov 29, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request external contributor This label marks the issues connected to Dework WORKING An issue in working

Comments

@darwintree
Copy link
Collaborator

Describe the feature or improvement 描述新特性或改进
Currently, there are some videos made for the documentation portal. We could embed videos in the pages.

Optional: Implementation ideas 可选:如何实现
We could use docusarus tab feature and stream media iframe link to complete the feature.

<Tabs>
  <TabItem value="youtube" label="Video source: youtube">
    <!-- insert youtube iframe link here -->
  </TabItem>
  <TabItem value="bilibili" label="Video source: bilibili">
    <!-- insert bilibili iframe link here -->
  </TabItem>
</Tabs>

The iframe link could be found in share -> embed for both youtube and bilibii. BTW, it should be noted that the bilibili video will be autoplayed for the default copied link. You should add &autoplay=0 after the url.

Example outcome:
image

  • I'd be willing to contribute this feature myself. 我将自己实现这个feature
@darwintree darwintree added the enhancement New feature or request label Nov 29, 2023
@darwintree
Copy link
Collaborator Author

An independent page for video? Or sidebar

@0xn1c0 0xn1c0 self-assigned this Dec 5, 2023
@0xn1c0
Copy link
Collaborator

0xn1c0 commented Dec 7, 2023

Added Nodes Video Tutorial at docs/general/run-a-node/

#308

@0xn1c0 0xn1c0 added the WORKING An issue in working label Dec 11, 2023
@darwintree darwintree added WORKING An issue in working and removed WORKING An issue in working labels Dec 12, 2023
@0xn1c0
Copy link
Collaborator

0xn1c0 commented Jan 15, 2024

Added videos to existing pages on this PR: #362

The creation of new pages is still pending. Next step is creating new pages in which to add the videos are weren't embedded yet.

@0xn1c0
Copy link
Collaborator

0xn1c0 commented Jan 25, 2024

Another video was added on this PR: #392

@0xn1c0
Copy link
Collaborator

0xn1c0 commented Jan 26, 2024

More videos added on this PR: #404

@0xn1c0 0xn1c0 added the external contributor This label marks the issues connected to Dework label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external contributor This label marks the issues connected to Dework WORKING An issue in working
Projects
None yet
Development

No branches or pull requests

2 participants