Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add\update containers #6383

Closed
6 tasks
Tracked by #5681
tbenr opened this issue Nov 5, 2022 · 2 comments · Fixed by #6434
Closed
6 tasks
Tracked by #5681

Add\update containers #6383

tbenr opened this issue Nov 5, 2022 · 2 comments · Fixed by #6434
Assignees
@zilm13
Labels
Epic Deneb Issues required to implement Deneb upgrade

Comments

@tbenr
Copy link
Contributor

tbenr commented Nov 5, 2022 •
edited
Loading

New SSZ containers

p2p containers

  • BlobsSidecar
  • SignedBeaconBlockAndBlobsSidecar

Updated SSZ containers

beacon containers

  • BeaconBlockBody
    • BeaconBlockBodyBuilder
  • ExecutionPayload
  • ExecutionPayloadHeader
@tbenr tbenr mentioned this issue Nov 5, 2022
Closed
58 tasks
@tbenr tbenr added the Epic Deneb Issues required to implement Deneb upgrade label Nov 5, 2022
@zilm13 zilm13 self-assigned this Nov 10, 2022
@zilm13
Copy link
Contributor

zilm13 commented Nov 10, 2022 •
edited
Loading

Looks like validator containers are no more actual with this PR merged
ethereum/consensus-specs#3038
one of the goals was to close this issue ethereum/consensus-specs#3026

we may need structure for this tuple, but it doesn't have a name at the moment https://github.com/ethereum/consensus-specs/blob/dev/specs/eip4844/validator.md?plain=1#L48

@tbenr
Copy link
Contributor Author

tbenr commented Nov 11, 2022

we may need structure for this tuple, but it doesn't have a name at the moment https://github.com/ethereum/consensus-specs/blob/dev/specs/eip4844/validator.md?plain=1#L48

That's implementation specific. I currently think we will pass around the "internal" version of blobsbundlev1 which I don't think it will be an ssz container.

Looks like validator containers ...

yeah, I haven't updated the issue after that pr was merged

@zilm13 zilm13 mentioned this issue Nov 12, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zilm13 zilm13

Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eip4844 containers zilm13/teku
2 participants
@zilm13 @tbenr