Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Handle global NPM packages #129

Closed
rocky opened this issue Mar 16, 2019 · 8 comments
Closed

Handle global NPM packages #129

rocky opened this issue Mar 16, 2019 · 8 comments
Assignees

Comments

@rocky
Copy link
Contributor

rocky commented Mar 16, 2019

Right now we handle locally-install npm packages. But what if openZepplin is installed globally?

@tagomaru
Copy link
Collaborator

This concept was implemented at this PR which did not be merged.

@rocky
Copy link
Contributor Author

rocky commented Mar 17, 2019

So if we merge that, we are then good? Or does this need to be reworked?

@tagomaru
Copy link
Collaborator

No, we already merged another one. This is not compatible for that. I work on it at a later date.

@tagomaru tagomaru self-assigned this Mar 17, 2019
@rocky
Copy link
Contributor Author

rocky commented Mar 17, 2019

The other thing to keep in mind is that if we use truffle-resolve things may change again. It might have to be worked into the NPM module instead of how it would be done now.

@tagomaru
Copy link
Collaborator

Yes, thanks, i know.
I think we should refer to that to handle npm and EthPM at the same time.

@tagomaru
Copy link
Collaborator

@rocky

Right now we handle locally-install npm packages. But what if openZepplin is installed globally?

According to my investigation, truffle itself does not support globally installed package.
So i think we do not have to resolve this.
I may send PR for supporting globally installed package to truffle-resolver itself at a later date.

@rocky
Copy link
Contributor Author

rocky commented Mar 22, 2019

Yes, building on truffle-resolver is the way to go.

@tagomaru
Copy link
Collaborator

yes i am closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants