Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Wasmer Reborn #503

Closed
2 of 9 tasks
webmaster128 opened this issue Aug 5, 2020 · 5 comments · Fixed by #504
Closed
2 of 9 tasks

Upgrade to Wasmer Reborn #503

webmaster128 opened this issue Aug 5, 2020 · 5 comments · Fixed by #504

Comments

@webmaster128
Copy link
Member

webmaster128 commented Aug 5, 2020

Before hitting 1.0, we want to migrate to the new version of Wasmer, which is currently in private beta.

I tried migrating straight to the new API, which turned out be almost impossible since I did not see any way to do that gradually. There is a compatibility wrapper around the new API, which turns out to be very promising and brings us to almost compiling.

Right now, we're blocked by the missing ability to get a memory given a Ctx.

@webmaster128 webmaster128 added this to the 0.11.0 milestone Aug 5, 2020
@webmaster128 webmaster128 self-assigned this Aug 5, 2020
@webmaster128 webmaster128 added the Blocked Blocked on some external dependency label Aug 5, 2020
@ethanfrey ethanfrey removed this from the 0.11.0 milestone Aug 20, 2020
@webmaster128 webmaster128 added this to the 1.0.0 milestone Sep 7, 2020
@webmaster128
Copy link
Member Author

Made some good progress here the last 2 days. (cd packages/vm && cargo +nightly check) now passes (test do not yet compile). However, I run in big trouble with the iterator feature ((cd packages/vm && cargo +nightly check --features iterator)) because of the lifetime of iterators (#335 (comment)). We might be able to do further progress by storing the context data as a void pointer like we did before, but now it becomes clear how unsafe that is.

@syrusakbary
Copy link

Note: Wasmer 1.0 doesn't require +nightly any longer for singlepass (you can use stable since Rust 1.45+) :)

@webmaster128 webmaster128 modified the milestones: 1.0.0, 0.12.0 Oct 15, 2020
@webmaster128 webmaster128 modified the milestones: 0.12.0, 0.13.0 Nov 3, 2020
@yun-yeo
Copy link

yun-yeo commented Nov 30, 2020

Made many updates for [email protected] . now yet released but can prepare update :)

Also they have update on int signal catch here wasmerio/wasmer#1552


seems after adopting v0.17.1 (int signal removed), test not finished. maybe due to infinite loop test?

@webmaster128
Copy link
Member Author

seems after adopting v0.17.1 (int signal removed), test not finished. maybe due to infinite loop test?

CosmWasm never used Wasmer 0.17.1 due to issues we had with it. We will migrate from 0.17.0 to 1.0.

@webmaster128
Copy link
Member Author

The original description is outdated. Once wasmerio/wasmer#1856 is closed, we can merge #504. Metering is disabled temporarily and will be reactivated in #642 before CosmWasm 0.13.

@webmaster128 webmaster128 removed the Blocked Blocked on some external dependency label Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants