Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it cheep to pin a contract that is already pinned #806

Closed
webmaster128 opened this issue Mar 1, 2021 · 0 comments · Fixed by #808
Closed

Make it cheep to pin a contract that is already pinned #806

webmaster128 opened this issue Mar 1, 2021 · 0 comments · Fixed by #808
Assignees
@webmaster128
Milestone
0.14.0

Comments

@webmaster128
Copy link
Member

This allows us to have a super simple implementation in wasmd. pin(x) should basically be a no-op when x is already in the PinnedMemoryCache. Right now we can have the case that a contract is loaded from disk, even if it is already pinned.
@webmaster128 webmaster128 added this to the 0.14.0 milestone Mar 1, 2021
@webmaster128 webmaster128 changed the title Make it cheep to pin a contract that is alread pinned Make it cheep to pin a contract that is already pinned Mar 1, 2021
@webmaster128 webmaster128 self-assigned this Mar 1, 2021
@webmaster128 webmaster128 mentioned this issue Mar 1, 2021
Merged
@mergify mergify bot closed this as completed in #808 Mar 1, 2021
@ethanfrey ethanfrey mentioned this issue Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webmaster128 webmaster128

Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Ensure pinning a contract that is already pinned is cheap CosmWasm/cosmwasm
1 participant
@webmaster128