Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asymmetries between query and execute in CW1 (subkeys) #145

Closed
willclarktech opened this issue Nov 26, 2020 · 2 comments
Closed

Asymmetries between query and execute in CW1 (subkeys) #145

willclarktech opened this issue Nov 26, 2020 · 2 comments
Assignees
@maurolacy

Comments

@willclarktech
Copy link

I noticed there are a couple of asymmetries between query and execute in the CW1 contract:

  1. Why is it called CanSend rather than CanExecute?
  2. Since Execute takes a vector of msgs why wouldn't CanSend also take a vector?
@maurolacy
Copy link
Contributor

You're right. The query name CanSend is probably for historical reasons. It would be better called CanExecute, as you say.
Regarding CanExecute accepting a vector of msgs, that's a nice improvement.

I'll implement the suggested changes.

@maurolacy maurolacy self-assigned this Nov 28, 2020
This was referenced Nov 28, 2020
Merged
Closed
@ethanfrey
Copy link
Member

I believe this can be closed.

The name was modified as requested, and we decided not to support mutliple messages in the query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ethanfrey @willclarktech @maurolacy