Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages for LastCodeID in initGenesis #643

Closed
fkneeland-figure opened this issue Oct 13, 2021 · 2 comments · Fixed by #644
Closed

Fix error messages for LastCodeID in initGenesis #643

fkneeland-figure opened this issue Oct 13, 2021 · 2 comments · Fixed by #644

Comments

@fkneeland-figure
Copy link
Contributor

fkneeland-figure commented Oct 13, 2021

The current error message in the initGenesis function if the lastCodeID is incorrect fails to print out the current but incorrect value. We should update the error statement to log all the fields to make debugging around this error easier in the future.

@alpe
Copy link
Contributor

alpe commented Oct 18, 2021

🤔 I don't see that the error message is incorrect. The sequence value(s) must be greater than the max id(s) we have from the import(s) of code/ contract infos so that we don't assign the same id(s) twice later.
Not sure if adding the current value to the log output is of any benefit to identify the problem. I am biased but for me it boils down to "seq %s must be greater %d ".

@fkneeland-figure
Copy link
Contributor Author

@alpe I will update the issue to just log the additional information as the error message is correct I just misread the code.

@alpe alpe closed this as completed in #644 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants