Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source and Builder flags need to be removed from gov tx store code command #647

Closed
iramiller opened this issue Oct 14, 2021 · 1 comment
Closed

Source and Builder flags need to be removed from gov tx store code command #647

iramiller opened this issue Oct 14, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@iramiller
Copy link
Contributor

Source and builder properties were removed from the protos but the Use line of the command still references these:

wasmd/x/wasm/client/cli/gov_tx.go

Line 18 in 6a471a4

Use: "wasm-store [wasm file] --source [source] --builder [builder] --title [text] --description [text] --run-as [address]",

@ethanfrey ethanfrey added this to the v1.0.0 milestone Oct 14, 2021
@fkneeland-figure fkneeland-figure mentioned this issue Oct 14, 2021
Merged
@alpe alpe added the good first issue Good for newcomers label Oct 18, 2021
@alpe
Copy link
Contributor

alpe commented Oct 18, 2021

Done. Thanks! 💐

@alpe alpe closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alpe @iramiller @ethanfrey