-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wasmvm aka go-cosmwasm #311
Conversation
726aff7
to
001d628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff lgtm. Just one thing.
c4d8260
to
1588cb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 17.49% 17.53% +0.03%
==========================================
Files 35 35
Lines 10505 10519 +14
==========================================
+ Hits 1838 1844 +6
- Misses 8566 8572 +6
- Partials 101 103 +2
Continue to review full report at Codecov.
|
Pushed a new version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more 💅 but looks nice overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these new command line flags to the README?
Otherwise, looks top.
Co-authored-by: Simon Warta <[email protected]>
Resolves #309
This got a bit bigger than expected:
go-ext-builder
WasmConfig
parsing--wasm.lru_cache_size
and--wasm.query_gas_limit
wasmd start parameterGORACE=halt_on_error=1