Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wasmvm aka go-cosmwasm #311

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Upgrade wasmvm aka go-cosmwasm #311

merged 4 commits into from
Nov 17, 2020

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 12, 2020

Resolves #309
This got a bit bigger than expected:

  • Rename go-cosmwasm to wasmvm
  • Upgrade wasmvm to `v0.12.0-alpha1
  • Upgrade Dockerfile for new go-ext-builder
  • Fix WasmConfig parsing
  • New --wasm.lru_cache_size and --wasm.query_gas_limit wasmd start parameter
  • Default "lru cache size" to 100 MiB
  • Upgrade CircleCI build container to Go 1.15
  • Stop tests on race conditions via GORACE=halt_on_error=1

@alpe alpe force-pushed the go_cosmwasm_upgrade_309 branch from 726aff7 to 001d628 Compare November 12, 2020 14:17
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm. Just one thing.

x/wasm/internal/keeper/keeper.go Outdated Show resolved Hide resolved
@alpe alpe force-pushed the go_cosmwasm_upgrade_309 branch from c4d8260 to 1588cb5 Compare November 13, 2020 11:23
@CosmWasm CosmWasm deleted a comment from codecov bot Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #311 (ac8437f) into master (cbda602) will increase coverage by 0.03%.
The diff coverage is 61.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   17.49%   17.53%   +0.03%     
==========================================
  Files          35       35              
  Lines       10505    10519      +14     
==========================================
+ Hits         1838     1844       +6     
- Misses       8566     8572       +6     
- Partials      101      103       +2     
Impacted Files Coverage Δ
x/wasm/internal/keeper/api.go 60.00% <ø> (ø)
x/wasm/internal/keeper/handler_plugin.go 75.34% <ø> (ø)
x/wasm/internal/types/types.go 23.52% <0.00%> (-0.24%) ⬇️
x/wasm/module.go 22.00% <40.00%> (+7.71%) ⬆️
x/wasm/internal/keeper/query_plugins.go 74.55% <80.00%> (ø)
app/app.go 88.38% <100.00%> (-0.10%) ⬇️
x/wasm/internal/keeper/keeper.go 90.30% <100.00%> (+0.60%) ⬆️
x/wasm/internal/keeper/test_common.go 86.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbda602...ac8437f. Read the comment docs.

@alpe
Copy link
Contributor Author

alpe commented Nov 13, 2020

Pushed a new version

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more 💅 but looks nice overall

.circleci/config.yml Outdated Show resolved Hide resolved
x/wasm/README.md Outdated Show resolved Hide resolved
x/wasm/README.md Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Outdated Show resolved Hide resolved
x/wasm/module.go Outdated Show resolved Hide resolved
x/wasm/module.go Outdated Show resolved Hide resolved
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these new command line flags to the README?

Otherwise, looks top.

cmd/wasmd/root.go Show resolved Hide resolved
x/wasm/internal/keeper/handler_plugin.go Show resolved Hide resolved
x/wasm/internal/keeper/keeper.go Outdated Show resolved Hide resolved
x/wasm/internal/types/types.go Show resolved Hide resolved
x/wasm/module.go Show resolved Hide resolved
x/wasm/module.go Show resolved Hide resolved
x/wasm/module_test.go Show resolved Hide resolved
@alpe alpe merged commit 93761ea into master Nov 17, 2020
@alpe alpe deleted the go_cosmwasm_upgrade_309 branch November 17, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go-cowasmwasm to wasmvm 0.12
3 participants