Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade wasmvm to 0.12.0 #319

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Upgrade wasmvm to 0.12.0 #319

merged 4 commits into from
Nov 19, 2020

Conversation

webmaster128
Copy link
Member

This includes the following (theoretically independent) changes:

  • Upgrade wasmvm to 0 12.0
  • Use pre-build .a library and remove the rust-builder
  • Upgrade Go from 1.14 to 1.15 by migrating from cosmwasm/go-ext-builder:0002-alpine to golang:1.15-alpine3.12
  • Add .dockerignore to avoid sending dozens of MB unneeded build results to the docker daemon

@webmaster128 webmaster128 requested a review from alpe November 19, 2020 15:03
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #319 (07855f8) into master (807956b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   17.67%   17.67%           
=======================================
  Files          35       35           
  Lines       10592    10592           
=======================================
  Hits         1872     1872           
  Misses       8606     8606           
  Partials      114      114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 807956b...07855f8. Read the comment docs.

@webmaster128 webmaster128 changed the title Upgrade wasmvm to 0 12.0 Upgrade wasmvm to 0.12.0 Nov 19, 2020
alpe
alpe approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful 💐
This is a great improvement to the docker build!

.dockerignore
@@ -0,0 +1,2 @@
# Folders we don't want to copy to Docker daemon in `docker build . -t cosmwasm/wasmd:latest`
build/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 good idea

Dockerfile
COPY --from=rust-builder /lib/libwasmvm_muslc.a /lib/libwasmvm_muslc.a
# See https://github.com/CosmWasm/wasmvm/releases
ADD https://github.com/CosmWasm/wasmvm/releases/download/v0.12.0/libwasmvm_muslc.a /lib/libwasmvm_muslc.a
RUN sha256sum /lib/libwasmvm_muslc.a | grep 00ee24fefe094d919f5f83bf1b32948b1083245479dad8ccd5654c7204827765
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@webmaster128
Copy link
Member Author

Thanks 😊

@webmaster128 webmaster128 merged commit 8ee7038 into master Nov 19, 2020
@webmaster128 webmaster128 deleted the upgrade-wasmvm-to-0-12.0 branch November 19, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @alpe