Refactor to GRPC message server #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 57.19% 56.02% -1.18%
==========================================
Files 33 34 +1
Lines 3453 3461 +8
==========================================
- Hits 1975 1939 -36
- Misses 1327 1376 +49
+ Partials 151 146 -5
|
ethanfrey
reviewed
Jan 8, 2021
| if msg.Admin != "" { | ||
| if adminAddr, err = sdk.AccAddressFromBech32(msg.Admin); err != nil { | ||
| return nil, sdkerrors.Wrap(err, "admin") | ||
| func hasWasmModuleAttribute(attrs []abci.EventAttribute) bool { |
There was a problem hiding this comment.
Why do we need this? I am a bit unsure and need to investigate the event/attribute system a bit more.
There were multiple sub-messages merging into each other before causing confusion. I will try some tests in a branch
There was a problem hiding this comment.
Saved follow up for #368 but not for 0.14.0 release
| repeated cosmos.base.v1beta1.Coin init_funds = 6 [(gogoproto.nullable) = false, (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins"]; | ||
| } | ||
| // MsgInstantiateContractResponse return instantiation result data | ||
| message MsgInstantiateContractResponse { |
There was a problem hiding this comment.
I do like these clear types for return value
ethanfrey
force-pushed
the
grpc_service_328
branch
from
89b79e5 to
33333da
Compare
|
I am good to merge this. I need to investigate the how events are handled better in the baseapp and tendermint levels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #328
This PR introduces support for the sdk grpc server to handle messages.
It introduces a breaking change to the response data that is returned. Instead of our custom data it is marshalled protobuf now. See
tx.protofor service and type definitionsLeft to do: