Stargate msg and query #435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 55.42% 55.36% -0.07%
==========================================
Files 39 39
Lines 4043 4073 +30
==========================================
+ Hits 2241 2255 +14
- Misses 1619 1627 +8
- Partials 183 191 +8
|
| @@ -20,8 +22,8 @@ type DefaultMessageHandler struct { | |||
| encoders MessageEncoders | |||
| } | |||
|
|
|||
| func NewDefaultMessageHandler(router sdk.Router, channelKeeper types.ChannelKeeper, capabilityKeeper types.CapabilityKeeper, customEncoders *MessageEncoders) DefaultMessageHandler { | |||
| encoders := DefaultEncoders(channelKeeper, capabilityKeeper).Merge(customEncoders) | |||
| func NewDefaultMessageHandler(router sdk.Router, channelKeeper types.ChannelKeeper, capabilityKeeper types.CapabilityKeeper, unpacker codectypes.AnyUnpacker, customEncoders *MessageEncoders) DefaultMessageHandler { | |||
There was a problem hiding this comment.
good use of the minimal interface
| @@ -276,6 +288,27 @@ func TestEncoding(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| // TODO: alpe? can you add an example with sub-interfaces (where the UnpackInterfaces call would be needed) | |||
There was a problem hiding this comment.
I am not sure how to create such a case. (I also think we only have bank, staking, and distribution registered here in the tests).
If you could add such a test to trigger this that would be great. Or if it is a pain, please open up an issue on it and explain more or less what is needed. I can put that down lower on the priority list
There was a problem hiding this comment.
I found Any types in sdk (master).
- MsgGrantAuthorizationRequest
- MsgGrantFeeAllowance
- MsgSubmitProposal
- MsgCreateValidator
I guessMsgSubmitProposalwould be a good candidate. I can add a test.
| @@ -276,6 +288,27 @@ func TestEncoding(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| // TODO: alpe? can you add an example with sub-interfaces (where the UnpackInterfaces call would be needed) | |||
There was a problem hiding this comment.
I found Any types in sdk (master).
- MsgGrantAuthorizationRequest
- MsgGrantFeeAllowance
- MsgSubmitProposal
- MsgCreateValidator
I guessMsgSubmitProposalwould be a good candidate. I can add a test.
| protoQuery := banktypes.QueryAllBalancesRequest{ | ||
| Address: creator.String(), | ||
| } | ||
| protoQueryBin, err := proto.Marshal(&protoQuery) |
There was a problem hiding this comment.
Clever to test with a different golang protobuf marshaller. 🌻
| var simpleBalance wasmvmtypes.AllBalancesResponse | ||
| mustParse(t, simpleChain.Data, &simpleBalance) | ||
| require.Equal(t, len(expectedBalance), len(simpleBalance.Amount)) | ||
| assert.Equal(t, simpleBalance.Amount[0].Amount, expectedBalance[0].Amount.String()) |
There was a problem hiding this comment.
nit: no need to change: wrong order of arguments. Here and others (t, expect, got) (to be fair it is not consistent within testify like assert.Len(t, got, exp)` )
|
Thanks. If you could add a follow up pr sometime with submit proposal, that would be great Now contracts can vote |
Closes #388