Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli alias #536

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Add cli alias #536

merged 2 commits into from
Jun 14, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jun 11, 2021

Resolves #496

@alpe alpe requested a review from ethanfrey June 11, 2021 12:07
@codecov
Copy link

codecov bot commented Jun 11, 2021 •
edited
Loading

Codecov Report

Merging #536 (7a4b425) into master (5252f22) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   58.56%   58.45%   -0.12%     
==========================================
  Files          43       43              
  Lines        4506     4518      +12     
==========================================
+ Hits         2639     2641       +2     
- Misses       1649     1660      +11     
+ Partials      218      217       -1
Impacted Files Coverage Δ
x/wasm/client/cli/new_tx.go 0.00% <0.00%> (ø)
x/wasm/client/cli/query.go 0.00% <0.00%> (ø)
x/wasm/client/cli/tx.go 25.69% <0.00%> (-0.55%) ⬇️
x/wasm/keeper/keeper.go 85.06% <0.00%> (+0.43%) ⬆️

ethanfrey
ethanfrey approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Added a few more suggestions

x/wasm/client/cli/new_tx.go Outdated Show resolved Hide resolved
x/wasm/client/cli/new_tx.go Outdated Show resolved Hide resolved
x/wasm/client/cli/tx.go Show resolved Hide resolved
x/wasm/client/cli/tx.go Outdated Show resolved Hide resolved
x/wasm/client/cli/tx.go Outdated Show resolved Hide resolved
@alpe alpe merged commit 6a6d6c9 into master Jun 14, 2021
@alpe alpe deleted the cli_alias_496 branch June 14, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cli alias
2 participants
@alpe @ethanfrey