Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ibc contract interface #570

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jul 28, 2021

Closes #561

We can make this less verbose once CosmWasm/wasmvm#254 is merged and tagger

@ethanfrey ethanfrey requested a review from alpe as a code owner July 28, 2021 20:16
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #570 (0fe0b62) into master (0dbcef0) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   59.45%   59.71%   +0.26%     
==========================================
  Files          45       45              
  Lines        5209     5208       -1     
==========================================
+ Hits         3097     3110      +13     
+ Misses       1882     1874       -8     
+ Partials      230      224       -6     
Impacted Files Coverage Δ
x/wasm/keeper/relay.go 100.00% <ø> (+11.32%) ⬆️
x/wasm/ibc.go 67.70% <100.00%> (+5.65%) ⬆️
x/wasm/keeper/keeper.go 85.47% <0.00%> (+0.36%) ⬆️

@ethanfrey ethanfrey requested a review from webmaster128 July 28, 2021 20:18
@ethanfrey
Copy link
Member Author

After merging this, I would cut a v0.18.0-rc1 as the remaining issues are mainly docs, with the possible change of an event type or two that we emit. Pretty close to release-ready API and something to cut CosmJS against

@@ -31,18 +31,6 @@ func (k Keeper) OnOpenChannel(
env := types.NewEnv(ctx, contractAddr)
querier := k.newQueryHandler(ctx, contractAddr)

msg := wasmvmtypes.IBCChannelOpenMsg{}
if counterpartyVersion == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice we don't need to rely on such logic anymore

@ethanfrey ethanfrey merged commit 0f6f437 into master Jul 29, 2021
@alpe alpe deleted the 561-better-ibc-contract-interface branch December 22, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Connect/Close callbacks in IbcContract interface into 2 variants.
2 participants