Implement PinCode and UnpinCode proposal client handlers #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 60.21% 59.24% -0.98%
==========================================
Files 48 48
Lines 5361 5449 +88
==========================================
Hits 3228 3228
- Misses 1903 1991 +88
Partials 230 230
|
alpe
reviewed
Dec 20, 2021
| @@ -14,4 +14,6 @@ var ProposalHandlers = []govclient.ProposalHandler{ | |||
| govclient.NewProposalHandler(cli.ProposalMigrateContractCmd, rest.MigrateProposalHandler), | |||
| govclient.NewProposalHandler(cli.ProposalUpdateContractAdminCmd, rest.UpdateContractAdminProposalHandler), | |||
| govclient.NewProposalHandler(cli.ProposalClearContractAdminCmd, rest.ClearContractAdminProposalHandler), | |||
| govclient.NewProposalHandler(cli.ProposalPinCodesCmd, rest.PinCodeProposalHandler), | |||
| govclient.NewProposalHandler(cli.ProposalUnpinCodesCmd, rest.UnpinCodeProposalHandler), | |||
| cmd.Flags().String(cli.FlagDeposit, "", "Deposit of proposal") | ||
| cmd.Flags().String(cli.FlagProposal, "", "Proposal file path (if this path is given, other proposal flags are ignored)") | ||
| // type values must match the "ProposalHandler" "routes" in cli | ||
| cmd.Flags().String(flagProposalType, "", "Permission of proposal, types: store-code/instantiate/migrate/update-admin/clear-admin/text/parameter_change/software_upgrade") |
There was a problem hiding this comment.
Not scope of this PR: this flag looks odd. It should be "Type" instead of "Permission" here and contain all possible types. I am unsure if it is still needed
alpe
suggested changes
Dec 22, 2021
Co-authored-by: Alexander Peters <[email protected]>
|
Thanks 💐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.