Autopin gov contracts #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 59.92% 59.90% -0.03%
==========================================
Files 49 49
Lines 5602 5604 +2
==========================================
Hits 3357 3357
- Misses 2002 2003 +1
- Partials 243 244 +1
|
|
@alpe This should be fine. I just don't cover the case of PinCode returning an error, thus the patch cover issue |
ethanfrey
force-pushed
the
702-autopin-gov-contracts
branch
from
231f2c8 to
e9d96cf
Compare
|
Changelog entry added. This should also be ready to merge (merge conflicts on CHANGELOG with #727 but we can just keep both lines) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #702
Simply calls pin after creation if we create it via a gov proposal