-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sudo and execute proposal types #730
Conversation
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 59.95% 58.32% -1.63%
==========================================
Files 49 49
Lines 5613 5807 +194
==========================================
+ Hits 3365 3387 +22
- Misses 2004 2170 +166
- Partials 244 250 +6
|
@alpe I think this is done and covered with tests. Can you please review and let me know how to test the cli better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
Please update the method doc in https://github.com/CosmWasm/wasmd/blob/master/x/wasm/keeper/keeper.go#L441
as it would not be correct anymore.
If you can add the new types to Governance.md
then this would be 🚀
Disclaimer:
I have checked that the CLI commands are listed in wasmd tx gov submit-proposal -h
but not executed a proposal
1a0f953
to
0a96e26
Compare
Thank you for the feedback. I have addressed all comments, and also added the funds field to the new execute contract proposal type. I also updated the changelog and this is ready to merge |
Closes #672
Closes #711