Use callback pattern for contract state iterator #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 58.73% 58.68% -0.05%
==========================================
Files 50 50
Lines 5857 5855 -2
==========================================
- Hits 3440 3436 -4
- Misses 2166 2167 +1
- Partials 251 252 +1
|
pinosu
approved these changes
Mar 25, 2022
Comment on lines
+691
to
+701
| // IterateContractState iterates through all elements of the key value store for the given contract address and passes | ||
| // them to the provided callback function. The callback method can return true to abort early. | ||
| func (k Keeper) IterateContractState(ctx sdk.Context, contractAddress sdk.AccAddress, cb func(key, value []byte) bool) { | ||
| prefixStoreKey := types.GetContractStorePrefix(contractAddress) | ||
| prefixStore := prefix.NewStore(ctx.KVStore(k.storeKey), prefixStoreKey) | ||
| return prefixStore.Iterator(nil, nil) | ||
| iter := prefixStore.Iterator(nil, nil) | ||
| defer iter.Close() | ||
|
|
||
| for ; iter.Valid(); iter.Next() { | ||
| if cb(iter.Key(), iter.Value()) { | ||
| break |
Comment on lines
+96
to
+99
| keeper.IterateContractState(ctx, contractAddr, func(key, value []byte) bool { | ||
| resultData = append(resultData, types.Model{Key: key, Value: value}) | ||
| return false | ||
| }) |
Comment on lines
+106
to
+109
| keeper.IterateContractState(ctx, addr, func(key, value []byte) bool { | ||
| state = append(state, types.Model{Key: key, Value: value}) | ||
| return false | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #792
Thanks @albertchon for bringing this up! 💐