-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SudoContractProposal and ExecuteContractProposal #808
Conversation
Will also be running some manual tests tomorrow to check if this resolves the issues we've seen with gov/sudo. EDIT: 🚀 |
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
==========================================
+ Coverage 58.76% 59.31% +0.54%
==========================================
Files 50 50
Lines 5862 5896 +34
==========================================
+ Hits 3445 3497 +52
+ Misses 2164 2145 -19
- Partials 253 254 +1
|
Update: we have run this on a testnet with a sudo contract and successfully moved funds via a gov prop. Our auto-CI hook that was failing with 0.25.0 also passes when we substitute in this branch, so we're pretty confident it's the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps @alpe wants to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 👍
I added just some minor comments.
Also it would be nice if you could update the description mentioning that also ExecuteContractProposal was added.
@pinosu have updated the description and some additional test cases as you suggested. |
Good find. I have a mental block with amino. Can't believe we still need to register all this stuff. |
Follow up fix for #730
Add missing
SudoContractProposal
andExecuteContractProposal
where it was missinng in types/codec and basic validation unit test.Could be some more to this that I've missed.