fix: allow no admin in instantiation through proposal #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 59.28% 59.36% +0.07%
==========================================
Files 51 51
Lines 5883 5884 +1
==========================================
+ Hits 3488 3493 +5
+ Misses 2143 2141 -2
+ Partials 252 250 -2
|
alpe
approved these changes
May 2, 2022
| if err != nil { | ||
| return sdkerrors.Wrap(err, "admin") | ||
| var adminAddr sdk.AccAddress | ||
| if p.Admin != "" { |
| @@ -123,6 +123,80 @@ func TestInstantiateProposal(t *testing.T) { | |||
| require.NotEmpty(t, em.Events()[2].Attributes[0]) | |||
| } | |||
|
|
|||
| func TestInstantiateProposal_NoAdmin(t *testing.T) { | |||
There was a problem hiding this comment.
Thanks for covering the additional cases! If you feel table tests are a better fit, then please feel free to refactor tests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently is not possible to instantiate without admin through governance proposal.