Add static build for macos #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@webmaster128 after this is merged, would it be possible to backport this to v1.2.0? Even it is just built and published in release assets would be nice. |
4 tasks
|
This was merged right before the 1.2.1 release. So it should be usable now. Could you try it out? See #407 for follow up discussions on that topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for building static wasmvm (universal) for
darwin.Here at Nibiru we would like to provide binaries for both
linuxanddarwin, without requesting users to manually install libraries. We are aware that going fully static onmacOSis hard (if not impossible), and we still need to link dynamically to system libraries, but at leastlibwasmvmcan be statically linked to our executable.With this changes, we can use a simple goreleaser config and goreleaser-cross to build binaries to all platforms.
NOTE:
I have included the built library under
internal/api/staticto make builds easier. But it is huge. If you prefer I can remove it and remove the cgo LDFLAGS and we add the flags to our build config instead.